Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] Upgrade passeport-saml 5.0 (#8379) #8657

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[backend] Upgrade passeport-saml 5.0 (#8379) #8657

merged 2 commits into from
Oct 16, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Oct 14, 2024 •
edited
Loading

Proposed changes

Note: cannot update xmldom to 0.9.2 since @nodesaml/nodesaml 5.0.0 is not compatible and there is no new versions.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@aHenryJard aHenryJard changed the title [backend] Upgrade of xmldom 0.9.2 and passeport-saml 5.0 (#8379) [backend] Upgrade passeport-saml 5.0 (#8379) Oct 14, 2024
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 14, 2024
aHenryJard
aHenryJard commented Oct 14, 2024
View reviewed changes
opencti-platform/opencti-graphql/package.json
"cross-fetch": "4.0.0",
"jose": "5.6.3",
"json5": "2.2.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to alphabetical order

@aHenryJard aHenryJard marked this pull request as ready for review October 14, 2024 13:49
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.05%. Comparing base (3497f88) to head (d1e6b73).
Report is 22 commits behind head on release/6.4.0.

Additional details and impacted files 
@@              Coverage Diff               @@
##           release/6.4.0    #8657   +/-   ##
==============================================
  Coverage          66.05%   66.05%           
==============================================
  Files                597      597           
  Lines              60871    60872    +1     
  Branches            6202     6204    +2     
==============================================
+ Hits               40206    40207    +1     
  Misses             20665    20665

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn self-requested a review October 16, 2024 07:47
@aHenryJard aHenryJard changed the base branch from master to release/6.4.0 October 16, 2024 08:27
@aHenryJard aHenryJard merged commit ef0f0c3 into release/6.4.0 Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lndrtrbn lndrtrbn lndrtrbn approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade passport saml to 5.x
2 participants
@aHenryJard @lndrtrbn